From:  pear-qa@lists.php.net ("mp@webfactory.de")
Date:  25 Nov 2015 20:50:57 Hong Kong Time
Newsgroup:  news.php.net/php.pear.bugs
Subject:  

[PEAR-BUG] Bug #17085 [Com]: Assigning the return value of new by reference is deprecated

NNTP-Posting-Host:  null

Edit report at https://pear.php.net/bugs/bug.php?id=17085&edit=1

 ID:               17085
 Comment by:       mp@webfactory.de
 Reported By:      seanmadden at mail dot rit dot edu
 Summary:          Assigning the return value of new by reference is
                    deprecated
 Status:           Wont fix
 Type:             Bug
 Package:          HTML_QuickForm
 Operating System: Fedora 11 x86_64 k:2.6.30.10-105
 Package Version:  3.2.11
 PHP Version:      5.3.1
 Roadmap Versions: 
 New Comment:

Could we please review this decision?

Getting no E_DEPRECATED level errors is an important step when preparing
the transition towards to PHP 7.

The changes required are fairly minimal and it should be possible to
review them even without tests.

Owners of mature code bases will hardly be able to switch over to
HTML_QuickForm2, given that there are lots of API changes.


Previous Comments:
------------------------------------------------------------------------

[2015-11-25 12:44:20] #a396102b9b59ad22b6f

Would it be possible to review this decision?

For us, getting no E_DEPRECATED errors is an important part of getting
PHP7-"ready". 

The changes required are minimal. Changing bigger, mature codebases over
to QuickForm2 (which is not API compliant) is not an option.

------------------------------------------------------------------------

[2010-02-13 15:47:10] avb

-Status: Open
+Status: Wont fix
Sorry, we won't fix that at this stage of the package's life cycle. We
don't have a test suite for QuickForm so can't easily check that it
doesn't break.

If you want to run with E_DEPRECATED and E_STRICT on, consider switching
to HTML_QuickForm2.

------------------------------------------------------------------------

[2010-02-10 19:07:57] spmadden

Added #patch bug:17085;patch:qf.patch;revision:1265828877;.

------------------------------------------------------------------------

[2010-02-10 19:05:56] spmadden

Description:
------------
With the latest version of PHP (5.3.1) using QuickForm with the E_STRICT
flags throws deprecated warnings with the use of assigning the value of
new by reference.

See the attached patch file for a fix.

Test script:
---------------



Expected result:
----------------
Blank Page.

Actual result:
--------------
Deprecated: Assigning the return value of new by reference is deprecated
in /usr/share/pear/HTML/QuickForm.php-old on line 597

Deprecated: Assigning the return value of new by reference is deprecated
in /usr/share/pear/HTML/QuickForm.php-old on line 1707

Deprecated: Assigning the return value of new by reference is deprecated
in /usr/share/pear/HTML/QuickForm.php-old on line 1864

------------------------------------------------------------------------


-- 
Edit this bug report at https://pear.php.net/bugs/bug.php?id=17085&edit=1