From:  bugzilla-request-daemon@mozilla.org
Date:  22 Jan 2006 17:00:50 Hong Kong Time
Newsgroup:  news.mozilla.org/netscape.public.mozilla.reviewers
Subject:  

superreview requested: [Bug 323472] Crash when Places imports FF1.5 bookmarks : [Attachment 209262] patch

NNTP-Posting-Host:  207.126.111.202

Brian Ryner  has asked Darin Fisher  for
superreview:
Bug 323472: Crash when Places imports FF1.5 bookmarks
https://bugzilla.mozilla.org/show_bug.cgi?id=323472

Attachment 209262: patch
https://bugzilla.mozilla.org/attachment.cgi?id=209262&action=edit

------- Additional Comments from Brian Ryner 
The first part of this patch is pretty straightforward.  I changed the
LivemarkInfo objects to be heap-allocated so we don't have to worry about them
moving.

I noticed another problem though -- it seems like we need to clean up somehow
if a livemark is removed when there's a pending LivemarkLoadListener for that
livemark.  I added a channel pointer to the LivemarkInfo object, and cancel the
channel before removing the livemark.  I think this should be ok -- darin, am I
missing any cases where I could end up with a dangling channel pointer, or the
pointer wouldn't get cleared as expected, or OnStopRequest could still fire
after the livemark is removed?