From:  bugzilla-request-daemon@mozilla.org
Date:  17 Jan 2006 06:59:35 Hong Kong Time
Newsgroup:  news.mozilla.org/netscape.public.mozilla.reviewers
Subject:  

superreview requested: [Bug 307527] Connection timeout with IMAP on dual core systems : [Attachment 208675] Proposed patch: use timeGetTime (whitespace ignored for code review)

NNTP-Posting-Host:  207.126.111.202

Wan-Teh Chang  has asked David Bienvenu
 for superreview:
Bug 307527: Connection timeout with IMAP on dual core systems
https://bugzilla.mozilla.org/show_bug.cgi?id=307527

Attachment 208675: Proposed patch: use timeGetTime (whitespace ignored for code
review)
https://bugzilla.mozilla.org/attachment.cgi?id=208675&action=edit

------- Additional Comments from Wan-Teh Chang 
The original code uses QueryPerformanceCounter if it
works, and falls back on GetTickCount.

This patch essentially has two changes.

1. Do not use QueryPerformanceCounter.	This is as
if _nt_ticksPerSec is a constant with value -1 and
only the code paths for _nt_ticksPerSec == -1 remain.

2. Use timeGetTime instead of GetTickCount because
timeGetTime has a finer resolution on most systems.
Unfortunately this requires linking with the system
library winmm.lib, which hurts the application startup
time.  But this is a safer change because I'm worried
that some code may need the higher resolution.