From:  f masood <12msccsfmasood@seecs.edu.pk>
Date:  24 Nov 2017 15:19:13 Hong Kong Time
Newsgroup:  news.mozilla.org/mozilla.dev.security
Subject:  

Re: adding a new custom ciphersuite to NSS (to be used by Thunderbird for TLS establishment)

NNTP-Posting-Host:  63.245.214.181

***Update***

so I was doing manual patching after looking the Camellia Cipher Patch in my Thunderbird NSS direcotry on Windows platform since I want to create the the binary on windows platform and I got the following issues:

i.	pk11table.c location changed

ii.	pk11pars.h file not found [cant patch the file]

iii.	sslimpl.h had number 64 and 40 in the patch, what number should I give, following lines from orignal:
		a. #define ssl_V3_SUITES_IMPLEMENTED 64

		b. #define ssl_V3_SUITES_IMPLEMENTED 40

iv. What numbers to assign cipher in secoid.c 


ps: this patch is very old, almost a decade old, can anyone guide me or provide me a slightly new patch please thanks?


On Friday, November 24, 2017 at 9:42:52 AM UTC+5, f masood wrote:
> Hello again, can anyone guide me ? Thanks. 
> On Wednesday, November 22, 2017 at 11:53:49 PM UTC+5, f masood wrote:
> > Hi
> > 
> > Hope everyone doing great. 
> > 
> > I have a small research oriented project in which I have to add a custom similar to AES like cipher to the NSS which will later be used by the Thunderbird for TLS establishment. 
> > 
> > Currently, I have added/defined my ciphers in the following files by doing my own limited research:
> > 
> > i. sslproto.h
> > ii. sslenum.c
> > iii. ssl3con.c
> > iv. ssl3ecc.c
> > 
> > the ciphersuite name is === TLS_ECDHE_ECDSA_WITH_MYAES_128_GCM_SHA256, HEX number given to it  === OXC02A
> > 
> > 
> > however when I compile the following error comes in:
> > ssl3con.c(184): error C2078 too many initalizers
> > ssl3con.c(293): error C2065 cipher myaes_128_gcm : undeclared identifier
> > 
> > and alot more errors ...
> > 
> > What should be the best approach or steps to successfully integrate a custom CIPHERSUITE, should I look at the "
> > Support for Camellia Cipher Suites to TLS RFC4132: Attachment #245822: patch for NSS trunk" and "SEED cipher" patches ?
> > 
> > I will be contributing to this open source society by providing a documentation/patch/video of what I have done which will benefit others.
> > 
> > Regards.