From:  William Bamberg <wbamberg@mozilla.com>
Date:  06 May 2017 01:19:36 Hong Kong Time
Newsgroup:  news.mozilla.org/mozilla.dev.mdc
Subject:  

Re: Need to update bookmarks API compatibility

NNTP-Posting-Host:  63.245.214.181

On Fri, May 5, 2017 at 10:07 AM, Gautham B A 
wrote:

> It’s a pleasure contributing to open source projects. 😊
>
> By the way, I still don’t see the edge browser compatibility status being
> updated - https://developer.mozilla.org/en-US/Add-ons/WebExtensions/
> API/bookmarks
>


Yes, I still need to update the macros that generate the tables[1] so they
use the new data source. I'm hoping to get that done in the next couple of
days.

[1] https://github.com/mozilla/kumascript/





>
>
> Sent from Mail  for
> Windows 10
>
>
>
> *From: *William Bamberg 
> *Sent: *05 May 2017 22:23
> *To: *Gautham B A 
> *Cc: *mozilla-dev-mdc@lists.mozilla.org
> *Subject: *Re: [dev-mdc] Need to update bookmarks API compatibility
>
>
>
> Merged! Thanks for your contribution Gautham.
>
>
>
> On Thu, May 4, 2017 at 11:30 AM, Gautham B A 
> wrote:
>
> Thanks William. I've updated the JSON file and created a pull request.
>
>
>
> On Thu, May 4, 2017 at 11:01 PM, William Bamberg 
> wrote:
>
> Hi Gautham
>
> We've now updated the WebExtensions data to the new schema, so you can
> update the docs.
>
> To update the bookmarks API data:
>
> ***
>
> 1. fork the https://github.com/mdn/browser-compat-data repo
>
> 2. clone your fork to your computer
>
>
> 3. find the "javascript-apis.json" file in the "webextensions" directory
>
>
> 4. find the section that covers the bookmarks API: this starts at line
> 169: https://github.com/mdn/browser-compat-data/blob/master/webextensions/
> javascript-apis.json#L169
>
>
> 5. find the 6 functions that MS have indicated are supported in Edge, and
> under each of them, in:
>
>     "__compat": {
>         "basic_support": {
>             "support": {
>                 "edge": {
>                     "version_added": false
>
> ...change *"version_added": false* to *"version_added": true*, or supply
> the actual version number if you know it.
>
> 6. commit your change, and push it back up to GitHub
>
> 7. make a pull request for us to merge it into mdn/browser-compat-data
>
> ***
>
> If you have any questions, please ask!
>
>
>
> Thanks!
>
> Will
>
>
>
> On Tue, May 2, 2017 at 10:48 AM, Gautham B A 
> wrote:
>
> Sir, it would be my honour to update this doc as this is going to be my
> first contribution. ☺
>
>
>
> Please let me know when the WebExtensions data will be updated to the new
> JSON schema so that I can update the doc.
>
>
>
> Thanks,
>
> --Gautham
>
>
>
> On May 2, 2017 11:05 PM, "William Bamberg"  wrote:
>
>
>
>
>
> On Sun, Apr 30, 2017 at 9:56 PM, Gautham B A 
> wrote:
>
> Hi all,
>
> With the recent creators update for Windows 10, the "bookmarks API" has
> been added to the Edge browser - https://docs.microsoft.com/en-
> us/microsoft-edge/extensions/api-support/supported-apis
>
>
>
> That's exciting! I did not know that.
>
>
>
>
>
>
> However, it seems like the bookmarks API documentation page on Mozilla -
> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/bookmarks
> has not been updated.
>
> I tried to edit the section "Browser compatibility" in the page. All I
> could find was "{{WebExtBrowserCompat}}" under it and nothing that I could
> edit to update the compatibility. Could someone please tell me if it's
> possible to edit the browser compatibility table in that page?
>
>
>
> The data used to build that table is stored here: https://github.com/mdn/
> browser-compat-data, and we happily accept pull requests...usually. Right
> now we are in the middle of updating the data to a new JSON schema, so I'd
> rather not take any updates to it. But I do hope that I will have updated
> the WebExtensions data in the next couple of days, and can let you know
> then if you would like to update it yourself. If you wouldn't like to
> update it yourself, I can :).
>
> I've filed https://github.com/mdn/browser-compat-data/issues/165 so no
> one forgets.
>
>
>
> Thanks!
>
> Will
>
>
>
>
>
>
>
>
>
> --
>
> Gautham
>
>
>
>
>